Add comprehensive defensive parsing tests for TraceState and Baggage propagators #3040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Co-authored-by: cijothomas <[email protected]>
Co-authored-by: cijothomas <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
cijothomas
June 27, 2025 16:07
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3040 +/- ##
=======================================
+ Coverage 80.0% 80.3% +0.2%
=======================================
Files 126 126
Lines 21879 22257 +378
=======================================
+ Hits 17519 17883 +364
- Misses 4360 4374 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds extensive defensive parsing tests for TraceState and Baggage propagators to ensure they handle malformed headers gracefully without crashes or security vulnerabilities, following the OpenTelemetry .NET security advisory.
Changes Made
TraceState Parsing (opentelemetry/src/trace/span_context.rs)
valid_key()validation: Now properly rejects empty keys and invalid vendor format edge casestest_tracestate_defensive_parsing: Tests malformed inputs including empty strings, invalid characters, Unicode, control characters, and very long inputstest_tracestate_memory_safety: Tests extremely long inputs (100k+ chars) and memory exhaustion protectiontest_tracestate_key_validation_edge_cases: Comprehensive tests for key validation rules per W3C spectest_tracestate_value_validation_edge_cases: Comprehensive tests for value validation rulesBaggage Parsing (opentelemetry-sdk/src/propagation/baggage.rs)
extract_baggage_defensive_parsing: Tests malformed baggage headers don't cause crashesextract_baggage_memory_safety: Tests memory safety with very long headers and many entries (10k+ entries)extract_baggage_percent_encoding_edge_cases: Tests invalid percent encoding patternsTraceContext Parsing (opentelemetry-sdk/src/propagation/trace_context.rs)
extract_w3c_defensive_traceparent: Tests malformed traceparent headersextract_w3c_defensive_tracestate: Tests malformed tracestate with valid traceparentextract_w3c_memory_safety: Tests memory safety with extremely long inputsextract_w3c_boundary_conditions: Tests boundary conditions for versions and flagsSecurity Improvements
The tests validate that the parsing code handles these attack vectors defensively:
Test Results
All tests pass successfully:
The existing parsing implementations already handle most malformed inputs gracefully by design, logging warnings and ignoring invalid entries. These tests ensure this defensive behavior is maintained and covers edge cases that could be exploited.
Fixes #2757.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.